Jimexist commented on a change in pull request #501:
URL: https://github.com/apache/arrow-datafusion/pull/501#discussion_r647889515
##########
File path: datafusion/src/sql/planner.rs
##########
@@ -2772,20 +2773,29 @@ mod tests {
"SELECT order_id, MAX(qty) OVER (), min(qty) over (), aVg(qty)
OVER () from orders";
let expected = "\
Projection: #order_id, #MAX(qty), #MIN(qty), #AVG(qty)\
- \n WindowAggr: windowExpr=[[MAX(#qty), MIN(#qty), AVG(#qty)]]
partitionBy=[]\
+ \n WindowAggr: windowExpr=[[MAX(#qty), MIN(#qty), AVG(#qty)]]\
\n TableScan: orders projection=None";
quick_test(sql, expected);
}
+ /// psql result
+ /// ```
+ /// QUERY PLAN
+ /// ----------------------------------------------------------------------
+ /// WindowAgg (cost=69.83..87.33 rows=1000 width=8)
+ /// -> Sort (cost=69.83..72.33 rows=1000 width=8)
+ /// Sort Key: order_id
+ /// -> Seq Scan on orders (cost=0.00..20.00 rows=1000 width=8)
+ /// ```
#[test]
- fn over_partition_by_not_supported() {
- let sql =
- "SELECT order_id, MAX(delivered) OVER (PARTITION BY order_id) from
orders";
- let err = logical_plan(sql).expect_err("query should have failed");
- assert_eq!(
- "NotImplemented(\"Unsupported OVER clause (PARTITION BY
order_id)\")",
- format!("{:?}", err)
- );
+ fn over_partition_by() {
+ let sql = "SELECT order_id, MAX(qty) OVER (PARTITION BY order_id) from
orders";
Review comment:
i think it can be added in a subsequent PR, where i can revisit all the
planning related printing (to be less verbose perhaps)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
