n3world commented on a change in pull request #10255:
URL: https://github.com/apache/arrow/pull/10255#discussion_r646629832
##########
File path: cpp/src/arrow/csv/chunker.cc
##########
@@ -235,10 +235,10 @@ class LexingBoundaryFinder : public BoundaryFinder {
return Status::OK();
}
- Status FindNth(util::string_view partial, util::string_view block, uint64_t
count,
- int64_t* out_pos, uint64_t* num_found) override {
+ Status FindNth(util::string_view partial, util::string_view block, int64_t
count,
Review comment:
Should I add asserts or checks that negative values are never passed in
then because right now the code does not handle negative values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
