yordan-pavlov commented on a change in pull request #384:
URL: https://github.com/apache/arrow-rs/pull/384#discussion_r646828767
##########
File path: parquet/src/util/mod.rs
##########
@@ -22,6 +22,4 @@ pub mod bit_util;
mod bit_packing;
pub mod cursor;
pub mod hash_util;
-
-#[cfg(test)]
Review comment:
I have changed this to
```rust
pub(crate) mod test_common;
pub use self::test_common::page_util::{InMemoryPageIterator,
DataPageBuilderImpl, DataPageBuilder};
```
in order to limit new public types to only `InMemoryPageIterator,
DataPageBuilderImpl, DataPageBuilder` which are used in benchmarks. I noticed
that this approach is already used here
https://github.com/apache/arrow-rs/blob/master/parquet/src/lib.rs#L45 and
thought this would be a much simpler solution compared to a new library crate.
@alamb let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
