yordan-pavlov commented on a change in pull request #384:
URL: https://github.com/apache/arrow-rs/pull/384#discussion_r645170853
##########
File path: arrow/src/array/data.rs
##########
@@ -506,6 +506,11 @@ impl ArrayDataBuilder {
self
}
+ pub fn null_count(mut self, null_count: usize) -> Self {
Review comment:
without this `null_count` method, `count_set_bits_offset` would be
called unnecessarily (because we already know the null count) a second time in
`ArrayData::new` when `value_array_data: ArrayData` is created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
