jonkeane commented on a change in pull request #10476:
URL: https://github.com/apache/arrow/pull/10476#discussion_r647637242
##########
File path: r/tests/testthat/test-compute-aggregate.R
##########
@@ -383,33 +383,30 @@ test_that("value_counts", {
})
test_that("any.Array and any.ChunkedArray", {
-
data <- c(1:10, NA, NA)
- expect_vector_equal(any(input > 5), data)
+ expect_vector_equal(any(input > 5, na.rm = TRUE), data)
Review comment:
[`expect_vector_equal` takes an expression and a
vector](https://github.com/apache/arrow/blob/ed4f79c77e5d34d5996fa287df0934dd2f93a12a/r/tests/testthat/helper-expectation.R#L159-L195)
and evaluates the expression in base R, then converts the vector converts it
into an array and evaluates the expression again (which typically will call
arrow compute functions), and finally converts the vector to a chunked array
and does the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
