jonkeane commented on a change in pull request #10476:
URL: https://github.com/apache/arrow/pull/10476#discussion_r647637941
##########
File path: r/tests/testthat/test-compute-aggregate.R
##########
@@ -383,33 +383,30 @@ test_that("value_counts", {
})
test_that("any.Array and any.ChunkedArray", {
-
data <- c(1:10, NA, NA)
- expect_vector_equal(any(input > 5), data)
+ expect_vector_equal(any(input > 5, na.rm = TRUE), data)
Review comment:
So the errors you're seeing indicate that we've got a mismatch in
behavior. I see that Ian has commented below about more robust tests + how to
match the behavior (but I'm happy to add to it if that's unclear!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
