lidavidm commented on pull request #10520: URL: https://github.com/apache/arrow/pull/10520#issuecomment-861509403
I was just thinking that. The current implementation already computes the output lengths (accounting for nullability) up front, so, it might not be too bad. I also noticed the current implementation effectively branches on scalar/array twice per column in the loop, trying to optimize that improved the cases with fewer columns at the expense of those with more columns (though that may be the right tradeoff). But I'll give the columnwise approach a try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
