pitrou commented on a change in pull request #10520:
URL: https://github.com/apache/arrow/pull/10520#discussion_r651984657
##########
File path: cpp/src/arrow/compute/kernels/scalar_string_benchmark.cc
##########
@@ -169,6 +169,48 @@ static void BinaryJoinArrayArray(benchmark::State& state) {
});
}
+static void BinaryJoinElementWise(benchmark::State& state,
+ SeparatorFactory make_separator) {
+ // Unfortunately benchmark is not 1:1 with BinaryJoin since BinaryJoin can
join a
+ // varying number of inputs per output
+ const int64_t n_strings = 1000;
Review comment:
I think this might be a bit low. For the few columns case, this may be
exposing some fixed cost overhead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
