edponce commented on a change in pull request #10567:
URL: https://github.com/apache/arrow/pull/10567#discussion_r655920884



##########
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##########
@@ -485,6 +644,37 @@ ArrayKernelExec ArithmeticExecFromOp(detail::GetTypeId 
get_id) {
   }
 }
 
+// For kernels that always return floating results
+template <template <typename... Args> class KernelGenerator, typename Op>
+ArrayKernelExec IntToDoubleExecFromOp(detail::GetTypeId get_id) {

Review comment:
       The variety of generator dispatchers available in the compute kernel are 
not consistent with their names. At some point we should rename them 
consistently, but that is out-of-scope for this PR. Nevertheless, I suggest to 
change the name of this generator dispatcher to 
`GenerateUnaryArithmeticFloatOutType`. This is simply a suggestion, we can 
rename later.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to