edponce commented on a change in pull request #10567:
URL: https://github.com/apache/arrow/pull/10567#discussion_r655927814
##########
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##########
@@ -485,6 +644,37 @@ ArrayKernelExec ArithmeticExecFromOp(detail::GetTypeId
get_id) {
}
}
+// For kernels that always return floating results
+template <template <typename... Args> class KernelGenerator, typename Op>
+ArrayKernelExec IntToDoubleExecFromOp(detail::GetTypeId get_id) {
Review comment:
*For context:* There are a variety of generator dispatchers in the
compute layer and their names are inconsistent (this is indirectly related to
ARROW-9161). There has been previous work in [renaming them for
consistency](https://github.com/apache/arrow/pull/7461#issuecomment-645623392)
but looking at the codebase, we will need another pass.
I suggest to change the name `IntToDoubleExecFromOp` to
`GenerateArithmeticWithFloatOutType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
