sgilmore10 commented on a change in pull request #10305:
URL: https://github.com/apache/arrow/pull/10305#discussion_r657180838
##########
File path: matlab/src/feather_reader.cc
##########
@@ -242,16 +245,34 @@ mxArray* FeatherReader::ReadVariables() const {
mxArray* variables =
mxCreateStructMatrix(1, num_variables_, num_variable_fields, fieldnames);
- // Read all the table variables in the Feather file into memory.
+ // Read the entire table in the Feather file into memory.
+ std::shared_ptr<arrow::Table> table = nullptr;
+ arrow::Status status = reader_->Read(&table);
+ if (!status.ok()) {
+ mexErrMsgIdAndTxt("MATLAB:arrow:FeatherReader::FailedToReadTable",
+ "Failed to read arrow::Table from Feather file.");
Review comment:
That's a good point. I'll update the error to include the status
message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
