sgilmore10 commented on a change in pull request #10305:
URL: https://github.com/apache/arrow/pull/10305#discussion_r658819952
##########
File path: matlab/src/feather_reader.cc
##########
@@ -52,11 +57,12 @@ mxArray* ReadNumericVariableData(const
std::shared_ptr<Array>& column) {
mxArray* variable_data =
mxCreateNumericMatrix(column->length(), 1, matlab_class_id, mxREAL);
- std::shared_ptr<ArrowArrayType> integer_array =
+ std::shared_ptr<ArrowArrayType> arrow_numeric_array =
std::static_pointer_cast<ArrowArrayType>(column);
// Get a raw pointer to the Arrow array data.
- const MatlabType* source = integer_array->raw_values();
+ const MatlabType* source =
+ reinterpret_cast<const
MatlabType*>(arrow_numeric_array->values()->data());
Review comment:
From the documentation, it looks like the values() method doesn't
account for slice offsets. I think we modified this line when we were trying to
get the code to compile again, but didn't check to see if this change was
really necessary. I just tried using raw_values() instead and it works. I'll
undo this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
