b41sh commented on a change in pull request #490:
URL: https://github.com/apache/arrow-rs/pull/490#discussion_r657722171
##########
File path: arrow/src/record_batch.rs
##########
@@ -426,6 +441,29 @@ mod tests {
assert_eq!(5, record_batch.column(1).data().len());
}
+ #[test]
+ fn create_record_batch_slice() {
Review comment:
@Jimexist I have a question, if an empty RecordBatch calls slice(), the
offset and length are zero, should we panic or return an empty RecordBatch
slice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
