jonkeane commented on a change in pull request #10601:
URL: https://github.com/apache/arrow/pull/10601#discussion_r658852266
##########
File path: r/tests/testthat/latin1.R
##########
@@ -35,12 +35,12 @@ expect_identical(Encoding(levels(df[[2]])), "latin1")
# Array
expect_identical(as.vector(Array$create(x)), x)
# struct
-expect_identical(as.vector(Array$create(df)), df)
+expect_identical(as.data.frame(Array$create(df)), df)
Review comment:
This is a change in interface, so we might also want to also make the
backwards compatibility option change this behavior too. The new behavior
seems more right here (especially in a world where not all structs are
dataframes), but we might want to be more careful than this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
