jonkeane commented on a change in pull request #10601:
URL: https://github.com/apache/arrow/pull/10601#discussion_r658859592



##########
File path: r/src/r_to_arrow.cpp
##########
@@ -1089,6 +1096,7 @@ class RStructConverter : public 
StructConverter<RConverter, RConverterTrait> {
       auto fields = this->struct_type_->fields();
       R_xlen_t n_columns = XLENGTH(values);
 
+      // TODO: this needs to be updated for the new struct situation like 
Extend above

Review comment:
       I haven't touched the `DelayedExtend` definition at all yet. I need to 
propagate the changes made in `Extend` here, and will once that approach is 
more solidified




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to