pitrou commented on pull request #10579: URL: https://github.com/apache/arrow/pull/10579#issuecomment-869731284
Hmm, it looks like the implementation could be more optimized. When appending multiple scalars (or multiple time the same scalars), the required space could be reserved. Also, at least for primitive types, I would expect appending multiple scalars to be much more streamlined than this. (it looks like such optimizations could be crafted more easily if `AppendScalar` was a bunch of virtual methods?) Perhaps create a TODO JIRA for those optimizations, unless you would like to work on them on this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
