lidavidm commented on a change in pull request #10579:
URL: https://github.com/apache/arrow/pull/10579#discussion_r660782135
##########
File path: cpp/src/arrow/array/builder_base.cc
##########
@@ -92,6 +95,163 @@ Status ArrayBuilder::Advance(int64_t elements) {
return null_bitmap_builder_.Advance(elements);
}
+namespace {
+struct AppendScalarImpl {
+ template <typename T>
+ enable_if_t<has_c_type<T>::value || is_decimal_type<T>::value, Status>
Visit(const T&) {
Review comment:
FixedSizeBinaryType didn't work with this specialization anyways, I'll
go add the required Builder::Append(Buffer) call that's needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
