alamb opened a new pull request #643:
URL: https://github.com/apache/arrow-datafusion/pull/643


   # Which issue does this PR close?
   
   Closes https://github.com/apache/arrow-datafusion/issues/642
   
   # Rationale for this change
   With the introduction of qualified identifiers in 
https://github.com/apache/arrow-datafusion/pull/55 I am having trouble creating 
plans with user defined nodes because the extension traits don't have 
sufficient information about the logical plan to create the correct 
`PhysicalExpr`s.
   
   https://github.com/apache/arrow-datafusion/issues/642 describes in more 
detail what is going on
   
   # What changes are included in this PR?
   1. Add a `PhysicalPlanner::create_physical_expr` to the planer trait
   2. Change the signature of `ExtensionPlanner::plan_extension` to include a 
reference to the planner as well as the logical inputs
   
   # Are there any user-facing changes?
   Yes: Extension API and PhysicalPlanner interfaces have changed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to