alamb commented on a change in pull request #643:
URL: https://github.com/apache/arrow-datafusion/pull/643#discussion_r661813799
##########
File path: datafusion/src/physical_plan/planner.rs
##########
@@ -210,6 +243,24 @@ impl PhysicalPlanner for DefaultPhysicalPlanner {
let plan = self.create_initial_plan(logical_plan, ctx_state)?;
self.optimize_plan(plan, ctx_state)
}
+
+ /// Create a physical expression from a logical expression
+ /// suitable for evaluation
+ ///
+ /// `e`: the expression to convert
+ ///
+ /// `input_dfschema`: the logical plan schema for evaluating `e`
+ ///
+ /// `input_schema`: the physical schema for evaluating `e`
+ fn create_physical_expr(
+ &self,
+ e: &Expr,
Review comment:
I agree `expr` is more consistent -- I think I was following the model
of `DefaultPhysicalPlanner::create_physical_expr`. I will change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
