bkietz commented on a change in pull request #10511: URL: https://github.com/apache/arrow/pull/10511#discussion_r660945979
########## File path: cpp/src/arrow/compute/function_internal.h ########## @@ -0,0 +1,577 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <sstream> +#include <string> +#include <vector> + +#include "arrow/array/builder_base.h" +#include "arrow/array/builder_binary.h" +#include "arrow/array/builder_nested.h" +#include "arrow/compute/api_vector.h" +#include "arrow/compute/function.h" +#include "arrow/compute/type_fwd.h" +#include "arrow/result.h" +#include "arrow/status.h" +#include "arrow/util/checked_cast.h" +#include "arrow/util/key_value_metadata.h" +#include "arrow/util/reflection_internal.h" +#include "arrow/util/string.h" +#include "arrow/util/visibility.h" + +namespace arrow { +struct Scalar; +struct StructScalar; +using ::arrow::internal::checked_cast; +namespace compute { +namespace internal { + +class GenericOptionsType : public FunctionOptionsType { + public: + Result<std::shared_ptr<Buffer>> Serialize(const FunctionOptions&) const override; + Result<std::unique_ptr<FunctionOptions>> Deserialize( + const Buffer& buffer) const override; + virtual Status ToStructScalar(const FunctionOptions& options, + std::vector<std::string>* field_names, + std::vector<std::shared_ptr<Scalar>>* values) const = 0; + virtual Result<std::unique_ptr<FunctionOptions>> FromStructScalar( + const StructScalar& scalar) const = 0; +}; + +ARROW_EXPORT +Result<std::shared_ptr<StructScalar>> FunctionOptionsToStructScalar( + const FunctionOptions&); +ARROW_EXPORT +Result<std::unique_ptr<FunctionOptions>> FunctionOptionsFromStructScalar( + const StructScalar&); + +template <typename Enum> +struct EnumTraits; + +template <typename Enum> +struct BasicEnumTraits { + using CType = typename std::underlying_type<Enum>::type; + using Type = typename CTypeTraits<CType>::ArrowType; +}; +template <> +struct EnumTraits<SortOrder> : BasicEnumTraits<SortOrder> { + static std::string name() { return "SortOrder"; } + static std::array<SortOrder, 2> values() { + return {SortOrder::Ascending, SortOrder::Descending}; + } +}; Review comment: Nevermind, doesn't work on GCC. https://godbolt.org/z/aoEca5zco EnumTraits would nevertheless be a reasonable place to put the string representations of enum values -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
