bkietz commented on a change in pull request #10511: URL: https://github.com/apache/arrow/pull/10511#discussion_r661541811
########## File path: cpp/src/arrow/compute/function_internal.h ########## @@ -0,0 +1,626 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <sstream> +#include <string> +#include <vector> + +#include "arrow/array/builder_base.h" +#include "arrow/array/builder_binary.h" +#include "arrow/array/builder_nested.h" +#include "arrow/compute/api_vector.h" +#include "arrow/compute/function.h" +#include "arrow/compute/type_fwd.h" +#include "arrow/result.h" +#include "arrow/status.h" +#include "arrow/util/checked_cast.h" +#include "arrow/util/key_value_metadata.h" +#include "arrow/util/reflection_internal.h" +#include "arrow/util/string.h" +#include "arrow/util/visibility.h" + +namespace arrow { +struct Scalar; +struct StructScalar; +using ::arrow::internal::checked_cast; + +namespace internal { +template <> +struct EnumTraits<compute::SortOrder> Review comment: Is there a reason to put this here instead of api_vector.cc? ########## File path: cpp/src/arrow/compute/api_scalar.h ########## @@ -188,23 +218,21 @@ enum CompareOperator : int8_t { LESS_EQUAL, }; -struct CompareOptions : public FunctionOptions { - explicit CompareOptions(CompareOperator op) : op(op) {} - +class ARROW_EXPORT CompareOptions : public FunctionOptions { + public: + explicit CompareOptions(CompareOperator op); Review comment: I see this is necessary; that's unfortunate. Could you open a follow up JIRA to remove the binding to `CompareOptions` and demote this to a deprecated struct? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
