rok commented on pull request #10610: URL: https://github.com/apache/arrow/pull/10610#issuecomment-872932527
> > Having another kernel to only change metadata seems redundant. > > I don't think that's redundant, as a user will regularly want to change the timezone of a timestamp column that is already localized (already has a timezone). > > I am of course coming from the point of view of pandas, where those two operations are defined as two distinct methods: tz_localize to convert from "timestamp without timezone" to "timestamp with timezone" (i.e. from naive clock time to tz-aware time) and tz_convert to convert between "timestamp with timezone" with different timezones (a metadata-only change). > From a user point of view (and also implementation-wise), those two are distinct concepts, IMO, and so I would keep them as separate kernels. (also eg R's lubridate has distinct `force_tz` and `with_tz`, respectively) I suppose these are two different operations indeed. I've changed to make this only "localization" now. I like `force_tz` as it indicates the operation is a bit "dangerous". Candidates are then: * force_tz * tz_localize * tz_normalize -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
