jorisvandenbossche commented on pull request #10610: URL: https://github.com/apache/arrow/pull/10610#issuecomment-877018432
> What I'm not sure about now is if try/catch is the way to go here I think the try/catch is fine, it's the way to convert an exception (which we don't use ourselves as return values) into a Status. > and how to return NaN when the timestamp is an int64. I think it should rather be a null instead of NaN (I suppose this is for the IGNORE case?), and nulls can be encoded in int64. I also think that the output type of the kernel should be timestamp _with_ timezone. > Another thing: `infer` requires understanding if the array is monotonous or not (if I understand correctly) and I'd push it out of scope of this PR for now. Yes, that's certainly something to be left/discussed for later, as it makes the kernel no longer a simple scalar kernel (where we can operate on each scalar independently element-wise), since the next scalar needs to have knowledge about the previous ones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
