houqp commented on a change in pull request #605:
URL: https://github.com/apache/arrow-datafusion/pull/605#discussion_r663447267
##########
File path: datafusion/src/physical_plan/hash_utils.rs
##########
@@ -104,46 +88,11 @@ fn check_join_set_is_valid(
/// Creates a schema for a join operation.
/// The fields from the left side are first
-pub fn build_join_schema(
- left: &Schema,
- right: &Schema,
- on: JoinOnRef,
- join_type: &JoinType,
-) -> Schema {
+pub fn build_join_schema(left: &Schema, right: &Schema, join_type: &JoinType)
-> Schema {
Review comment:
same schema build simplification as the one we introduced in logical
plan builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
