Jimexist commented on a change in pull request #605:
URL: https://github.com/apache/arrow-datafusion/pull/605#discussion_r664543555
##########
File path: datafusion/src/optimizer/filter_push_down.rs
##########
@@ -96,12 +96,21 @@ fn get_join_predicates<'a>(
let left_columns = &left
.fields()
.iter()
- .map(|f| f.qualified_column())
+ .map(|f| {
+ std::iter::once(f.qualified_column())
+ // we need to push down filter using unqualified column as well
+ .chain(std::iter::once(f.unqualified_column()))
Review comment:
same as
https://github.com/apache/arrow-datafusion/pull/605/files#r664543206
##########
File path: datafusion/src/optimizer/filter_push_down.rs
##########
@@ -96,12 +96,21 @@ fn get_join_predicates<'a>(
let left_columns = &left
.fields()
.iter()
- .map(|f| f.qualified_column())
+ .map(|f| {
+ std::iter::once(f.qualified_column())
+ // we need to push down filter using unqualified column as well
+ .chain(std::iter::once(f.unqualified_column()))
+ })
+ .flatten()
.collect::<HashSet<_>>();
let right_columns = &right
.fields()
.iter()
- .map(|f| f.qualified_column())
+ .map(|f| {
+ std::iter::once(f.qualified_column())
Review comment:
same as
https://github.com/apache/arrow-datafusion/pull/605/files#r664543206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
