bkietz commented on a change in pull request #10664:
URL: https://github.com/apache/arrow/pull/10664#discussion_r664743485
##########
File path: cpp/src/arrow/dataset/scanner.cc
##########
@@ -428,6 +428,11 @@ class ARROW_DS_EXPORT AsyncScanner : public Scanner,
Result<FragmentGenerator> GetFragments() const;
std::shared_ptr<Dataset> dataset_;
+
+ // XXX if Scanner were truly single-use this would be a 1:1 relationship
+ std::unordered_map<std::shared_ptr<compute::ExecPlan>,
+ std::shared_ptr<compute::ExecContext>>
+ plans_;
Review comment:
Well I originally did this because the destruction of ExecPlan was
waiting for the plan to finish, blocking the only thread which could finish the
plan. However removing it doesn't seem to reproduce the deadlock so I guess
`stop_producing` is a sufficient keepalive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
