bkietz commented on a change in pull request #10664:
URL: https://github.com/apache/arrow/pull/10664#discussion_r664744956
##########
File path: cpp/src/arrow/dataset/scanner.cc
##########
@@ -428,6 +428,11 @@ class ARROW_DS_EXPORT AsyncScanner : public Scanner,
Result<FragmentGenerator> GetFragments() const;
std::shared_ptr<Dataset> dataset_;
+
+ // XXX if Scanner were truly single-use this would be a 1:1 relationship
Review comment:
I'll write a follow up JIRA. Many of the unit tests assume a scanner can
be reused, and it'll be a change in behavior in the Python API too since we
expose Scanner there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
