alamb commented on a change in pull request #488:
URL: https://github.com/apache/arrow-rs/pull/488#discussion_r664773209
##########
File path: arrow/Cargo.toml
##########
@@ -40,7 +40,10 @@ serde = { version = "1.0", features = ["rc"] }
serde_derive = "1.0"
serde_json = { version = "1.0", features = ["preserve_order"] }
indexmap = "1.6"
-rand = "0.7"
+rand = { version = "0.8", default-features = false }
+# getrandom is a dependency of rand, not (directly) of arrow
+# need to specify `js` feature to build on wasm
+getrandom = { version = "0.2", features = ["js"] }
Review comment:
I tried this and sadly I am told:
```shell
alamb@ip-10-0-0-124:~/Software/arrow-rs/arrow$ cargo build --target
wasm32-unknown-unknown
error: failed to parse manifest at
`/Users/alamb/Software/arrow-rs/arrow/Cargo.toml`
Caused by:
feature `getrandom/js` in dependency `rand` is not allowed to contain
slashes
If you want to enable features of a transitive dependency, the direct
dependency needs to re-export those features from the `[features]` table.
```
```diff
alamb@ip-10-0-0-124:~/Software/arrow-rs/arrow$ git diff Cargo.toml
diff --git a/arrow/Cargo.toml b/arrow/Cargo.toml
index 478f33678..f6255a93d 100644
--- a/arrow/Cargo.toml
+++ b/arrow/Cargo.toml
@@ -40,10 +40,7 @@ serde = { version = "1.0", features = ["rc"] }
serde_derive = "1.0"
serde_json = { version = "1.0", features = ["preserve_order"] }
indexmap = "1.6"
-rand = { version = "0.8", default-features = false }
-# getrandom is a dependency of rand, not (directly) of arrow
-# need to specify `js` feature to build on wasm
-getrandom = { version = "0.2", features = ["js"] }
+rand = { version = "0.8", default-features = false, features =
["getrandom/js"] }
num = "0.4"
csv_crate = { version = "1.1", optional = true, package="csv" }
regex = "1.3"
alamb@ip-10-0-0-124:~/Software/arrow-rs/arrow$
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
