alamb commented on a change in pull request #488:
URL: https://github.com/apache/arrow-rs/pull/488#discussion_r664774759
##########
File path: arrow/Cargo.toml
##########
@@ -40,7 +40,10 @@ serde = { version = "1.0", features = ["rc"] }
serde_derive = "1.0"
serde_json = { version = "1.0", features = ["preserve_order"] }
indexmap = "1.6"
-rand = "0.7"
+rand = { version = "0.8", default-features = false }
+# getrandom is a dependency of rand, not (directly) of arrow
+# need to specify `js` feature to build on wasm
+getrandom = { version = "0.2", features = ["js"] }
Review comment:
Sadly, it appears this workaround is the recommended way from `rand`
rate: https://crates.io/crates/rand
> WASM support
>
> The WASM target wasm32-unknown-unknown is not automatically supported by
rand or getrandom. To solve this, either use a different target such as
wasm32-wasi or add a direct dependancy on getrandom with the js feature (if the
target supports JavaScript). See getrandom#WebAssembly support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
