shanhuuang commented on a change in pull request #10627:
URL: https://github.com/apache/arrow/pull/10627#discussion_r665023770
##########
File path: cpp/src/parquet/encoding.cc
##########
@@ -2062,17 +2061,12 @@ class DeltaBitPackDecoder : public DecoderImpl, virtual
public TypedDecoder<DTyp
explicit DeltaBitPackDecoder(const ColumnDescriptor* descr,
MemoryPool* pool =
::arrow::default_memory_pool())
- : DecoderImpl(descr, Encoding::DELTA_BINARY_PACKED), pool_(pool) {
- if (DType::type_num != Type::INT32 && DType::type_num != Type::INT64) {
Review comment:
I thought that DeltaBitPackDecoder object would only be created in
function parquet::MakeDecoder, so no more check is needed here. It's ok to
restore this code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
