lidavidm commented on a change in pull request #10664:
URL: https://github.com/apache/arrow/pull/10664#discussion_r665758000
##########
File path: cpp/src/arrow/compute/exec/exec_plan.cc
##########
@@ -282,20 +305,21 @@ struct SourceNode : ExecNode {
void StopProducing(ExecNode* output) override {
DCHECK_EQ(output, outputs_[0]);
- {
- std::unique_lock<std::mutex> lock(mutex_);
- finished_ = true;
- }
- finished_fut_.Wait();
+ StopProducing();
}
- void StopProducing() override { StopProducing(outputs_[0]); }
+ void StopProducing() override {
+ std::unique_lock<std::mutex> lock(mutex_);
+ stop_requested_ = true;
+ }
+
+ Future<> finished() override { return finished_; }
private:
std::mutex mutex_;
- bool finished_{false};
- int next_batch_index_{0};
- Future<> finished_fut_ = Future<>::MakeFinished();
+ bool stop_requested_{false};
Review comment:
There's an issue (ARROW-12938) for letting a StopToken run a callback
since it's needed to support other things like gRPC (which also exposes a
cancel method instead taking a cancellable context). But that'd be more work
and requires dealing with signal safety in the callback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
