bkietz commented on a change in pull request #10664:
URL: https://github.com/apache/arrow/pull/10664#discussion_r666329817
##########
File path: cpp/src/arrow/compute/exec/plan_test.cc
##########
@@ -144,7 +144,14 @@ TEST(ExecPlan, DummyStartProducing) {
// Note that any correct reverse topological order may do
ASSERT_THAT(t.started, ElementsAre("sink", "process3", "process2",
"process1",
"source2", "source1"));
- ASSERT_EQ(t.stopped.size(), 0);
+
+ plan->StopProducing();
+ plan->finished().Wait();
Review comment:
I've updated the tests to reuse the default wait
##########
File path: cpp/src/arrow/compute/exec/plan_test.cc
##########
@@ -144,7 +144,14 @@ TEST(ExecPlan, DummyStartProducing) {
// Note that any correct reverse topological order may do
ASSERT_THAT(t.started, ElementsAre("sink", "process3", "process2",
"process1",
"source2", "source1"));
- ASSERT_EQ(t.stopped.size(), 0);
+
+ plan->StopProducing();
+ plan->finished().Wait();
+ ASSERT_THAT(t.stopped, ElementsAre("source1", "source2", "process1",
"process2",
Review comment:
I'll duplicate the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
