edponce edited a comment on pull request #10683: URL: https://github.com/apache/arrow/pull/10683#issuecomment-879172919
@amol- The issue I find with `None` is that it doesn't provide any useful info w.r.t. to what value it is representing. Consider the case where a default C++ option is `std::numeric_limits<int64_t>::min()` then mapping `None` to also mean `-sys.maxsize-1` is inconsistent. Maybe another approach is to use `None` in Python for all options with a default value in C++, and let the C++ layer establish the actual default value. But using `None` will not allow viewing the default values in the exposed options signatures (e.g., when using Python's `help` command). For this PR, I added explicit type `int64_t` to the range limits of `SliceOptions`. cc @bkietz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
