edponce edited a comment on pull request #10683:
URL: https://github.com/apache/arrow/pull/10683#issuecomment-879185656


   Related to this PR and discussion, some default values in Cython are 
explicitly typed but others do not (e.g., `int64_t pivot` in 
[`PartitionNthOptions`](https://github.com/apache/arrow/blob/master/python/pyarrow/_compute.pyx#L858).
 Why are not all options in Cython explicitly typed?
   
   My recommendation is to provide explicit types to the function options in 
both class levels: the C extension and the Python derived class. I created 
[ARROW-13327](https://issues.apache.org/jira/browse/ARROW-13327) to help 
address strict typing in PyArrow bindings.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to