rok commented on pull request #10610: URL: https://github.com/apache/arrow/pull/10610#issuecomment-880920360
Thanks for the review @jorisvandenbossche! :) > > Shall we leave this PR as is then? > > I would then remove this option (if we keep it in the PR, it should do the correct thing IMO, while not it is still returning 0 (i.e. 1970-01-01) instead I think?) Removed the `IGNORE` option and made [ARROW-13347](https://issues.apache.org/jira/browse/ARROW-13347) to discuss/remember. > Can you also handle the case of an unknown / wrong timezone? Added but not at `TemporalLocalizationOptions` initialization but in [the TzLocalize exec](https://github.com/apache/arrow/pull/10610/files#diff-53850537a2f3f7977473b30241fdd3ddb35aa97269284c06471d9b0c599e2c59R86) since state can be returned from there. I think this is ready for another review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
