rok commented on pull request #10610: URL: https://github.com/apache/arrow/pull/10610#issuecomment-880645806
> > > > and how to return NaN when the timestamp is an int64. > > > > > > I think it should rather be a null instead of NaN (I suppose this is for the IGNORE case?), and nulls can be encoded in int64. > > > > Yes I was thinking about the IGNORE case. This should now return nulls but zeros are returned. Do we need to switch away from `ScalarUnaryNotNullStateful` for this? > > If it makes the implementation more complicated (as it would no longer simply propagate nulls), I think it is fine to also leave this option for a future enhancement I suppose it would. Shall we leave this PR as is then? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
