jonkeane commented on a change in pull request #10724:
URL: https://github.com/apache/arrow/pull/10724#discussion_r671519775
##########
File path: r/R/dplyr-functions.R
##########
@@ -634,20 +634,45 @@ nse_funcs$wday <- function(x, label = FALSE, abbr = TRUE,
week_start = getOption
}
nse_funcs$log <- function(x, base = exp(1)) {
-
+
if (base == exp(1)) {
return(Expression$create("ln_checked", x))
}
-
+
if (base == 2) {
return(Expression$create("log2_checked", x))
}
-
+
if (base == 10) {
return(Expression$create("log10_checked", x))
- }
+ }
# ARROW-13345
stop("`base` values other than exp(1), 2 and 10 not supported in Arrow",
call. = FALSE)
}
nse_funcs$logb <- nse_funcs$log
+
+nse_funcs$if_else <- function(condition, true, false, missing = NULL){
+ if (!is.null(missing)) {
+ arrow_not_supported("missing argument")
+ }
+
+ # TODO: if_else doesn't yet support factors/dictionaries this can be removed
when
+ # ARROW-13358 merges
+ warn_r_types <- is.factor(true) || is.factor(false)
+ # However, if they are expressions, we need to use the functions from
nse_funcs
+ warn_expression_types_true <- inherits(true, "Expression") &&
nse_funcs$is.factor(true)
+ warn_expression_types_false <- inherits(false, "Expression") &&
nse_funcs$is.factor(false)
+
+ if (warn_r_types | warn_expression_types_true | warn_expression_types_false)
{
+ warning("Factors are currently converted to chracters in if_else and
ifelse", call. = FALSE)
+ }
Review comment:
I've added both dictionary+factor and string+character to the warning. I
agree about talking about this type of casting/coalescing in a vignette
somewhere when it happens in the cases where it's more-or-less unavoidable.
Though in this case, like @lidavidm says, the casting is (hopefully) only
temporary so we should be able to pull this out next release (or maybe even
before then if the extra functionality is added soon enough).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
