nealrichardson commented on a change in pull request #10724:
URL: https://github.com/apache/arrow/pull/10724#discussion_r671579805
##########
File path: r/R/dplyr-functions.R
##########
@@ -634,20 +659,45 @@ nse_funcs$wday <- function(x, label = FALSE, abbr = TRUE,
week_start = getOption
}
nse_funcs$log <- function(x, base = exp(1)) {
-
+
if (base == exp(1)) {
return(Expression$create("ln_checked", x))
}
-
+
if (base == 2) {
return(Expression$create("log2_checked", x))
}
-
+
if (base == 10) {
return(Expression$create("log10_checked", x))
- }
+ }
# ARROW-13345
stop("`base` values other than exp(1), 2 and 10 not supported in Arrow",
call. = FALSE)
}
nse_funcs$logb <- nse_funcs$log
+
+nse_funcs$if_else <- function(condition, true, false, missing = NULL){
+ if (!is.null(missing)) {
+ return(nse_funcs$if_else(
+ is.na(condition),
Review comment:
Is it better to explicitly call the nse_func here?
```suggestion
nse_funcs$is.na(condition),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
