lidavidm commented on a change in pull request #10659: URL: https://github.com/apache/arrow/pull/10659#discussion_r672332383
########## File path: cpp/thirdparty/versions.txt ########## @@ -42,7 +42,7 @@ ARROW_JEMALLOC_BUILD_VERSION=5.2.1 ARROW_LZ4_BUILD_VERSION=v1.9.3 # mimalloc 1.6.7 didn't build on Visual Studio 2015 # https://github.com/microsoft/mimalloc/issues/353 -ARROW_MIMALLOC_BUILD_VERSION=v1.6.4 +ARROW_MIMALLOC_BUILD_VERSION=v1.7.2 Review comment: As far as I can see that should only apply to 2.0.0 and 1.7.x should be safe (the commenter in https://github.com/microsoft/mimalloc/issues/363 claims 1.7.0 doesn't affect them at least) ########## File path: cpp/thirdparty/versions.txt ########## @@ -42,7 +42,7 @@ ARROW_JEMALLOC_BUILD_VERSION=5.2.1 ARROW_LZ4_BUILD_VERSION=v1.9.3 # mimalloc 1.6.7 didn't build on Visual Studio 2015 # https://github.com/microsoft/mimalloc/issues/353 -ARROW_MIMALLOC_BUILD_VERSION=v1.6.4 +ARROW_MIMALLOC_BUILD_VERSION=v1.7.2 Review comment: And the problematic test is still there - so assuming tests pass we should be OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
