kszucs commented on a change in pull request #10659: URL: https://github.com/apache/arrow/pull/10659#discussion_r672328515
########## File path: cpp/thirdparty/versions.txt ########## @@ -42,7 +42,7 @@ ARROW_JEMALLOC_BUILD_VERSION=5.2.1 ARROW_LZ4_BUILD_VERSION=v1.9.3 # mimalloc 1.6.7 didn't build on Visual Studio 2015 # https://github.com/microsoft/mimalloc/issues/353 -ARROW_MIMALLOC_BUILD_VERSION=v1.6.4 +ARROW_MIMALLOC_BUILD_VERSION=v1.7.2 Review comment: @lidavidm how can I verify that https://github.com/apache/arrow/pull/10024 doesn't apply here? ########## File path: cpp/thirdparty/versions.txt ########## @@ -42,7 +42,7 @@ ARROW_JEMALLOC_BUILD_VERSION=5.2.1 ARROW_LZ4_BUILD_VERSION=v1.9.3 # mimalloc 1.6.7 didn't build on Visual Studio 2015 # https://github.com/microsoft/mimalloc/issues/353 -ARROW_MIMALLOC_BUILD_VERSION=v1.6.4 +ARROW_MIMALLOC_BUILD_VERSION=v1.7.2 Review comment: Thanks! ########## File path: cpp/cmake_modules/FindSnappyAlt.cmake ########## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +set(find_package_args) Review comment: Reverted. ########## File path: dev/tasks/python-wheels/github.osx.arm64.yml ########## @@ -0,0 +1,128 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Prerequisits on the host: +# - brew install bash bison coreutils ninja cmake +# - sudo arrow/ci/scripts/install_python.sh macos 3.9 + +{% import 'macros.jinja' as macros with context %} + +{{ macros.github_header() }} + +env: + ARROW_S3: {{ arrow_s3 }} + ARROW_FLIGHT: OFF + ARROW_JEMALLOC: OFF + ARROW_SIMD_LEVEL: NONE + CC: "clang" + CMAKE_CXX_COMPILER_LAUNCHER: "ccache" Review comment: We need this to use ccache when compiling the vcpkg binaries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
