pachadotdev commented on pull request #10650: URL: https://github.com/apache/arrow/pull/10650#issuecomment-884395025
> > Hi > > I was asking Alessandro about the new changes, and his concern (which I share), is if create_branch will just commit the files if the branch already exists. It might just crash with branch "nightly-json-reports" already exists. > > We shouldn't use crossbow to actually commit the new files to the branch. We can simply use plain git commands to commit the new files from a github actions cron job. > > > @kszucs do we have a way to try that code and confirm that running save_report_data twice doesn't crash but correctly commits two report files one after another on separate runs? > > 1. We should choose a filename which is unique per task. A good candidate for that is the task's branch, like `nightly-2021-01-16-0-github-test-conda-python-3.7-pandas-master` > > 2. This functionality should be idempotent given a task (like the task id/branch above), so we can choose to simply overwrite those files, though this shouldn't happen due to the daily scheduling which will always query the tasks belonging to the latest nightly job. thanks !! now we are talking about something where I have some experience, it it better do call a bash script from the python code, or to define cron tasks right away from gh-actions? the major drawback from the 2nd approach is that not all OS are tested on gh-actions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
