seddonm1 commented on a change in pull request #778:
URL: https://github.com/apache/arrow-datafusion/pull/778#discussion_r677028886
##########
File path: datafusion/src/logical_plan/builder.rs
##########
@@ -282,14 +282,28 @@ impl LogicalPlanBuilder {
));
}
- let left_keys: Vec<Column> = left_keys
- .into_iter()
- .map(|c| c.into().normalize(&self.plan))
- .collect::<Result<_>>()?;
- let right_keys: Vec<Column> = right_keys
- .into_iter()
- .map(|c| c.into().normalize(right))
- .collect::<Result<_>>()?;
+ let (left_keys, right_keys): (Vec<Result<Column>>,
Vec<Result<Column>>) =
Review comment:
> Welcome back @seddonm1 ! It is great to see a contribution from you.
Thank you very much
Thanks @alamb. Unfortunately my employment situation makes it hard to
contribute too much but I am still very interested in seeing Datafusion succeed.
The `LogicalPlanBuilder::join` has `left` and `right` keys but they are
`left` and `right` relative to a join condition not to a `left` or `right`
relation.
The `left_keys` and `right_keys` are where the join conditions are resolved
to underlying relations. The Postgres behavior does not require a specific
order of conditions for joining so we need to be able to handle both conditions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
