seddonm1 commented on a change in pull request #778:
URL: https://github.com/apache/arrow-datafusion/pull/778#discussion_r677031075
##########
File path: datafusion/tests/sql.rs
##########
@@ -1754,51 +1779,70 @@ async fn equijoin_and_unsupported_condition() ->
Result<()> {
#[tokio::test]
async fn left_join() -> Result<()> {
let mut ctx = create_join_context("t1_id", "t2_id")?;
- let sql = "SELECT t1_id, t1_name, t2_name FROM t1 LEFT JOIN t2 ON t1_id =
t2_id ORDER BY t1_id";
- let actual = execute(&mut ctx, sql).await;
+ let equivalent_sql = [
Review comment:
My main objective was to ensure nothing specific to equijoin (`INNER`)
would break this implementation for the other join types (which occurred when
developing it). This may be more relevant if any further optimisations occur.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
