jonkeane commented on a change in pull request #10710:
URL: https://github.com/apache/arrow/pull/10710#discussion_r677450840
##########
File path: r/inst/build_arrow_static.sh
##########
@@ -54,7 +67,7 @@ ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
-DARROW_COMPUTE=ON \
-DARROW_CSV=ON \
-DARROW_DATASET=${ARROW_DATASET:-ON} \
- -DARROW_DEPENDENCY_SOURCE=BUNDLED \
+ -DARROW_DEPENDENCY_SOURCE=${ARROW_DEPENDENCY_SOURCE} \
Review comment:
Yeah, partially: I suspect that there were builds where it was triggered
because the names of the variables lined up just right and that's where you saw
that, but at least on the latest build I'm seeing the same number of "Looking
for" on both.
But also like neal mentioned up top, setting the env var with `-e` for the
runtime only will make sure it gets in the place we need it without having to
worry about passing it around. (I'm going to add a bit more to my comment up
there since the comment mostly related to that...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
