jonkeane commented on a change in pull request #10710:
URL: https://github.com/apache/arrow/pull/10710#discussion_r677453784



##########
File path: .env
##########
@@ -67,6 +67,7 @@ R_ORG=rhub
 R_IMAGE=ubuntu-gcc-release
 R_TAG=latest
 TZ=UTC
+R_STATIC_DEPENDENCY_SOURCE=BUNDLED

Review comment:
       And for here, I would do ~the opposite of what I said yesterday, we want 
something like `-e ARROW_DEPENDENCY_SOURCE=...` in the docker call since that's 
the environment variable that we advertise and use throughout Arrow to 
determine that source.
   
   Yesterday I mentioned calling it something like `R_STATIC_DEP...` in the 
`.env` file, which if we needed to pass it there would be good to mark that it 
only was getting passed to the R builds and wasn't a parameter that would help 
on a python build. But Neal's right that we should just put it in the docker 
command in the GHA workflow file and not worry about passing it around in 
docker-compose or the .env file. Sorry for my misdirection there yesterday!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to