alamb commented on a change in pull request #788:
URL: https://github.com/apache/arrow-datafusion/pull/788#discussion_r677807928
##########
File path: datafusion/src/scalar.rs
##########
@@ -1336,4 +1346,12 @@ mod tests {
assert!(result.to_string().contains("Inconsistent types in
ScalarValue::iter_to_array. Expected Boolean, got Int32(5)"),
"{}", result);
}
+
+ #[test]
+ fn size_of_scalar() {
+ // Since ScalarValues are used in a non trivial number of places,
+ // making it larger means significant more memory consumption
+ // per distinct value.
+ assert_eq!(std::mem::size_of::<ScalarValue>(), 32);
Review comment:
here is the test showing the size decrease
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
