alamb commented on a change in pull request #788:
URL: https://github.com/apache/arrow-datafusion/pull/788#discussion_r680986891
##########
File path: datafusion/src/scalar.rs
##########
@@ -65,8 +65,9 @@ pub enum ScalarValue {
Binary(Option<Vec<u8>>),
/// large binary
LargeBinary(Option<Vec<u8>>),
- /// list of nested ScalarValue
- List(Option<Vec<ScalarValue>>, DataType),
+ /// list of nested ScalarValue (boxed to reduce size_of(ScalarValue))
+ #[allow(clippy::box_vec)]
+ List(Option<Box<Vec<ScalarValue>>>, Box<DataType>),
Review comment:
@jhorstmann I think using `Vec::into_boxed_slice` would be just fine. I
don't think `ScalarValues` are often (ever?) updated after creation so using a
boxed slice seems like a good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
