rommelDB commented on a change in pull request #10843:
URL: https://github.com/apache/arrow/pull/10843#discussion_r680131459
##########
File path: cpp/src/arrow/json/converter_test.cc
##########
@@ -96,5 +96,27 @@ TEST(ConverterTest, Timestamp) {
AssertConvert(timestamp(TimeUnit::SECOND), src, src);
}
+TEST(ConverterTest, Decimal128) {
+ std::string src = R"([
+ "02.0000000000",
+ "30.0000000000",
+ "22.0000000000",
+ "-121.0000000000",
+ null])";
+
+ AssertConvert(decimal128(38, 10), src, src);
Review comment:
The test is confusing because we use the same string representation to
produce the expected one. I think that rewriting this test should be clear such
confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
