rommelDB commented on a change in pull request #10843:
URL: https://github.com/apache/arrow/pull/10843#discussion_r680237364
##########
File path: cpp/src/arrow/json/converter_test.cc
##########
@@ -96,5 +96,27 @@ TEST(ConverterTest, Timestamp) {
AssertConvert(timestamp(TimeUnit::SECOND), src, src);
}
+TEST(ConverterTest, Decimal128) {
+ std::string src = R"([
+ "02.0000000000",
+ "30.0000000000",
+ "22.0000000000",
+ "-121.0000000000",
+ null])";
+
+ AssertConvert(decimal128(38, 10), src, src);
Review comment:
@felipeblazing I just did a refactoring of the tests, and now I think
the intention is much clearer. So now, the expected and input values are
separate instances, both in JSON format. Namely, the first is an array from
JSON that holds the expected values, and the second one is a one object per
line JSON table as the input string (thank you @bkietz for your support here).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
