JayjeetAtGithub commented on a change in pull request #10431:
URL: https://github.com/apache/arrow/pull/10431#discussion_r683281057
##########
File path: cpp/src/arrow/dataset/discovery.cc
##########
@@ -270,7 +270,14 @@ Result<std::shared_ptr<Dataset>>
FileSystemDatasetFactory::Finish(FinishOptions
for (const auto& info : files_) {
auto fixed_path = StripPrefixAndFilename(info.path(),
options_.partition_base_dir);
ARROW_ASSIGN_OR_RAISE(auto partition, partitioning->Parse(fixed_path));
- ARROW_ASSIGN_OR_RAISE(auto fragment, format_->MakeFragment({info, fs_},
partition));
+ std::shared_ptr<FileFragment> fragment;
+ if (format_->type_name() == "skyhook") {
+ ARROW_ASSIGN_OR_RAISE(fragment,
+ format_->MakeFragment({info, fs_}, partition,
true, schema));
Review comment:
Removed this change. Turns out this is not required anymore with dataset
schema populated automatically in ScanOptions.
##########
File path: cpp/src/arrow/dataset/scanner.cc
##########
@@ -32,6 +32,10 @@
#include "arrow/dataset/dataset.h"
#include "arrow/dataset/dataset_internal.h"
#include "arrow/dataset/scanner_internal.h"
+#include "arrow/io/memory.h"
Review comment:
Scanner.cc does not need any change anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
